Writing a library for OM-sharp and OMCS library

[paulohgraposo]

Hi everyone!
I am trying to adapt a OM library to OM-sharp. Since I am new to the latter, I have a few questions about how to proceed:

• It is necessary to include a package.lisp file inside the “sources” directory?

• In my first attempt (link below) i have included a code (in-package :om) inside the main lisp file, where all the library functions are located… Is this correct?

• About writing example patches, I am trying to insert some comments and I am always getting this error message:
  

  My last question is about the OMCS library. The calculations of All Intervals Series is not working in OM-sharp version and it is exactly the same patch used in OM. Am I doing something wrong? Any suggestions about this?
  

  
  
  
  
  

PHRaposo/OM-sharp-AIS

Best Regards,

Paulo.

[bresson]

Hi Paulo,

In principle you shouldn’t need to change your code to adapt your OM library for OM#.
You can just use the same source code (and the same repository), and add a OM-AIS.omlib file in it.

At the difference with the “.lisp” file that loads the OM library, the “.omlib” file doesn’t contain Lisp code that is evaluated, so you can not add such thing as (defpackage ...), or (print "...") in it. If you need to do so, you can indeed add another file in the sources (package.lisp) where the package is defined.
Then again, you shouldn’t have to make any change in the rest of the sources.

[bresson]

@paulohgraposo

I am trying to insert some comments and I am always getting this error message:

Can you precise how you are doing that ?

[bresson]

@paulohgraposo

The calculations of All Intervals Series is not working in OM-sharp version and it is exactly the same patch used in OM. Am I doing something wrong? Any suggestions about this?

Could you attach an actual patch maybe ?

[paulohgraposo]

Hi Jean,
Thank you for your response and suggestions.
I have just made this file with another version of the library. I had to make just a little change in OM’s code and change the location of a folder (AIS). I don’t know if is this correct, but apparently its working.

OM-AIS-OM-sharp-test.zip

Best Regards,

Paulo

[paulohgraposo]

Hi Jean,

 Sorry, I forgot to include the attachment. 

AIS-calculations.opat (95.4 KB)

[paulohgraposo]

I was trying to insert a comment inside the patch, but now the error message is gone.

[smalllotus]

Hi Paulo,

I tested your library with OM 6.17 and OM# and it seems to work on both softs, Congrats…
Let’s wait and see what Jean has to say…

Best,

Jerome

[paulohgraposo]

Hi Jerome.
Thank you for testing the library.

Best,

Paulo.

[bresson]

@paulohgraposo

Thank you for your response and suggestions.
I have just made this file with another version of the library. I had to make just a little change in OM’s code and change the location of a folder (AIS). I don’t know if is this correct, but apparently its working

I haven’t had a chance to thoroughly test but at a quick glance this seems to be it. Your .omlib file just loads the file as it is supposed to.

Two minor things:

• you can remove the (print ...) from the .omlib file, since it won’t be evaluated anyway
• you could also remove the (defpackage :OM-AIS ...) from OM-AIS.lisp and just load the file package.lisp instead, in order to avoid duplication of the package definition in your sources.

[bresson]

@paulohgraposo

I was trying to insert a comment inside the patch, but now the error message is gone.

The problem is (was) that you redefine in your code the function string-to-list that already exists in OM#. As long as it is redefined in your own package, this is fine, but I think in the previous version of your library you interned all your code in the OM package, and therefore redefined this internal function with a different number of arguments.

[paulohgraposo]

Hi Jean,
thanks again. I’ve followed your suggestions and it’s working perfectly. I appreciate your explanation about the string-to-list function and I’m beginning to understand the packages definitions now.
This is the new file:

OM-AIS-OM-sharp-test2.zip

Now there is only the problem with OMCS library in OM-sharp (the patch is also in AIS library tutorial).

Best,

Paulo.

[paulohgraposo]

Dear Jean,

this is the correct link:

OM-AIS-OM-sharp-test2.zip

Please disregard the previous one.

Best,

Paulo

[bresson]

@paulohgraposo

The calculations of All Intervals Series is not working

Can you be more specific ? What do you see ?

[bresson]

On my side: I see a stack overflow on omcs::search-engine (which means that the engine can not find a solution). It would be interesting to see if the exact same input values on all inputs of pmc-engine yield the same behavior in OM6.x
I don’t see why the solver would behave differently, but maybe it does

[paulohgraposo]

Hi Jean,
these are the results in OM6.17:

All the other rules are working too (for selecting prime form AIS and invariants).

[paulohgraposo]

A minor update of the problem: on OM#, when I change the sols-mode of the pmc-engine input to :once it works. When I try to evaluate 100 solutions it works too. The problem seem to be with the :all sols-mode of the pmc-engine or when a great number os solutions is required (I’ve tried 3856 solutions and the same problem of stack overflow appears).

[bresson]

Hi Paulo. I can see what is different: We need PMC engine to be compiled in order to run that patch, and currently OM# only loads and evaluates the (un-compiled) Lisp sources of the OMCS library.
=> I just uploaded this update of OMCS 1.2, which includes up-to-date compiled files for OM#/macOS (and should still work on OM6 as well):
https://github.com/openmusic-project/OMCS/releases/download/v1.2/OMCS.1.2-omsharp-macos.zip

[paulohgraposo]

Hi Jean,
thank you very much!

Best,

Paulo.

[perti]

hello,

is there any documentation for the use of omcs library? or some tutorial?
thanks in advance,
perti